Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probd blocks #156

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Probd blocks #156

wants to merge 4 commits into from

Conversation

AbmSourav
Copy link

proBD Blocks is a block-based version of the proBD theme.

@kjellr kjellr added block-based theme A theme using HTML templates needs testing labels Jan 4, 2021
@pbking
Copy link
Collaborator

pbking commented Feb 5, 2021

There seem to be some PHP errors from setup.php where the color palettes are being added. This seemed to bring the whole site editor down so I couldn't evaluate much further.

As an alternative to adding those color palettes via PHP I suggest instead including them exclusively in the experimental-theme.json file instead. I don't believe there would be a reason in your theme to have them in both locations. As a test I simply removed

 31     $this->editor_font_size();
 32     
 33     $this->editor_color_palette();
 34     
 35     $this->editor_gradient_palette();

from setup.php and things seemed to run OK.

@carolinan
Copy link
Collaborator

Hi, do you plan to update this to the newest formats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-based theme A theme using HTML templates feedback requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants